Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Eric Solioz
Eric Solioz
6,252 Points

Hi guys! Need some help. Thx.

I can't fix it.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }


    set major(major) {
      if ( major === 'Junior' || major === 'Senior') {
        this._major = major;
      } else if ( major === 'Freshman' || major === 'Sophomore' ) {
        this._major = 'None';
      }
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

}

var student = new Student(3.9, 60);

3 Answers

Daniel Boisselle
.a{fill-rule:evenodd;}techdegree
Daniel Boisselle
Front End Web Development Techdegree Student 17,438 Points 
  set major (major) {
      let level = this.level;

      if (level === 'Senior' || level === 'Junior') this._major = major;
      else this._major = "None";
  }

It looks like you're trying to check the Students 'Grade' with their 'Major'

The flow:

depending on the Students grade level either set the major or set it to 'None'

Hope this helps! Dan

Adam Beer
Adam Beer
11,314 Points
Adam Beer
Adam Beer
11,314 Points

Hi Eric! I don't know this course.I think if you change inside the if/else statement the major property to this.level your code it works. Hope this help.

Eric Solioz
Eric Solioz
6,252 Points
Eric Solioz
Eric Solioz
6,252 Points

Thank guys! It solved!