Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Ceil-Ian Maralit
.a{fill-rule:evenodd;}techdegree seal-36
Ceil-Ian Maralit
Front End Web Development Techdegree Graduate 19,434 Points

Query Selectors gone wrong

I don't know what's wrong here.

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
let listItems = document.querySelectorAll('#rainbow');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
Julian French
Julian French
3,257 Points

You're welcome. I hope that works for you.

Ceil-Ian Maralit
.a{fill-rule:evenodd;}techdegree seal-36
Ceil-Ian Maralit
Front End Web Development Techdegree Graduate 19,434 Points

Yes it did. Thank you!

1 Answer

Julian French
Julian French
3,257 Points

Hey! I would say it's better to do:

document.querySelectorAll('li');

Using "#rainbow" in your querySelectorAll wouldn't work because the # points to an id, and ids are supposed to be unique - only one tag should have a specific id. Now, if you wanted each li item to have the same class, you could make each li like this:

<li class="rainbow">This should be red</li>
<li class="rainbow">This should be orange</li>

That would allow you to select all of the li items that have the class of rainbow. So, the JavaScript would look like this:

document.querySelectorAll('.rainbow');
Ceil-Ian Maralit
.a{fill-rule:evenodd;}techdegree seal-36
Ceil-Ian Maralit
Front End Web Development Techdegree Graduate 19,434 Points

Thank you so much!