Stuck trying to pass number values into a function

Question

function max (a, b) {
  if(a>b) return a;
  else if(b>a) return b;
}

max(5, 8);

alert( max( ) ):

The alert is asking me if I passed the numbers correctly into the max function. Not sure what I'm doing wrong.

script.js

function max (a, b) {
  if(a>b) return a;
  else if(b>a) return b;
}

max(5, 8);

alert( max( ) );

Answer 1 · 2017-03-19T02:32:59Z

March 19, 2017 2:32am

1) You have a bit too much logic. You don't need the second if statement, as you only have two outcomes.

2) You should be passing the values directly into the function within the alert

function max(a, b) {
  if( a > b )
    return a;
  else
    return b;
}

alert( max(5, 8) );

Alternatively, you could put the alerts directly into the function and then run it by itself:

function max(a, b) {
  if( a > b )
    alert( a );
  else
    alert( b );
}

max(5, 8);

Answer 2 · 2017-03-19T00:11:43Z

March 19, 2017 12:11am

replace the colon with a semi-colon on your last line

Welcome to the Treehouse Community